test(admin, recurring): add AdminModule and RecurringModule test coverage - #559
Merged
BigBen-7 merged 2 commits intoAug 29, 2026
Merged
Conversation
Add comprehensive unit tests for AdminModule and RecurringModule: - admin.test.ts: proposeAdmin, acceptAdmin, getPendingAdmin, pause, unpause, setProtocolFee, dividendDistribute - recurring.test.ts: executeAllDue categorisation at scale, amendRecurring requiring at least one mutable field Also make amendRecurring throw READ_ONLY_CLIENT when no keypair is available, and include required paused field in RecurringRecord parsing. Closes Lead-Studios#468 Closes Lead-Studios#469 Closes Lead-Studios#470 Closes Lead-Studios#471
|
@khaadish Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds unit test coverage for the recurring and admin modules.
Tests added
Source changes
All 42 tests pass.
Closes #468
Closes #469
Closes #470
Closes #471